Hi Sakari, On 23-Jan-25 10:14 AM, Sakari Ailus wrote: > Hi Andy, > > On Wed, Jan 22, 2025 at 06:51:06PM +0200, Andy Shevchenko wrote: >> On Wed, Jan 22, 2025 at 12:43:44PM +0200, Sakari Ailus wrote: >>> The DT bindings for ov7251 specify "enable" GPIO (xshutdown in >>> documentation) but the int3472 indiscriminately provides this as a "reset" >>> GPIO to sensor drivers. Take this into account by assigning it as "enable" >>> with active high polarity for INT347E devices, i.e. ov7251. "reset" with >>> active low polarity remains the default GPIO name for other devices. >> >> ... >> >>> +/** >>> + * struct int3472_gpio_map - Map GPIOs to whatever is expected by the >>> + * sensor driver (as in DT bindings) >>> + * @hid: The ACPI HID of the device without the instance number e.g. i2c-INT347E >> >> W/o "i2c-" part. >> >>> + * @type_from: The GPIO type from ACPI ?SDT >>> + * @type_to: The assigned GPIO type, typically same as type_from >> >> @type_from > > Agreed. > >> >>> + * @func: The function, e.g. "enable" >> >> Should we speak in terms of GPIOLIB, like connection ID ? > > That rename should be done in the entire driver probably then. I can post a > patch if Hans agrees, after this one. Yes renaming func to con_id makes sense, but that should indeed be a separate change in a follow-up patch. Regards, Hans
