On Fri, 17 Jan 2025, Mark Pearson wrote: > > > On Fri, Jan 17, 2025, at 3:45 PM, Mark Pearson wrote: > > Hi, > > > > On Fri, Jan 17, 2025, at 12:19 PM, Ilpo Järvinen wrote: > >> On Fri, 17 Jan 2025, Kurt Borja wrote: > >> > >>> On Fri Jan 17, 2025 at 11:42 AM -05, Ilpo Järvinen wrote: > >>> > On Thu, 16 Jan 2025, Mark Pearson wrote: > >>> > > >>> > > Hi > >>> > > > >>> > > On Wed, Jan 15, 2025, at 7:27 PM, Kurt Borja wrote: > >>> > > > Hi :) > >>> > > > > >>> > > > The merge window is about to open, so I rebased this patchset on top of > >>> > > > pdx86/review-ilpo-next to pick up acer-wmi latest commits, in case we > >>> > > > manage to squeeze this into v6.14. > >>> > > > > >>> > > > ~ Kurt > >>> > > > --- > >>> > > > v3 -> v4: > >>> > > > > >>> > > > [09/19] > >>> > > > - Replace error message with a user-friendly one > >>> > > > > >>> > > > v3: > >>> > > > https://lore.kernel.org/platform-driver-x86/20250115071022.4815-1-kuurtb@xxxxxxxxx/ > >>> > > > > >>> > > > Kurt Borja (19): > >>> > > > ACPI: platform_profile: Replace *class_dev member with class_dev > >>> > > > ACPI: platform_profile: Let drivers set drvdata to the class device > >>> > > > ACPI: platform_profile: Remove platform_profile_handler from callbacks > >>> > > > ACPI: platform_profile: Add `ops` member to handlers > >>> > > > ACPI: platform_profile: Add `probe` to platform_profile_ops > >>> > > > platform/surface: surface_platform_profile: Use > >>> > > > devm_platform_profile_register() > >>> > > > platform/x86: acer-wmi: Use devm_platform_profile_register() > >>> > > > platform/x86: amd: pmf: sps: Use devm_platform_profile_register() > >>> > > > platform/x86: asus-wmi: Use devm_platform_profile_register() > >>> > > > platform/x86: dell-pc: Use devm_platform_profile_register() > >>> > > > platform/x86: ideapad-laptop: Use devm_platform_profile_register() > >>> > > > platform/x86: hp-wmi: Use devm_platform_profile_register() > >>> > > > platform/x86: inspur_platform_profile: Use > >>> > > > devm_platform_profile_register() > >>> > > > platform/x86: thinkpad_acpi: Use devm_platform_profile_register() > >>> > > > ACPI: platform_profile: Remove platform_profile_handler from exported > >>> > > > symbols > >>> > > > ACPI: platform_profile: Move platform_profile_handler > >>> > > > ACPI: platform_profile: Clean platform_profile_handler > >>> > > > ACPI: platform_profile: Add documentation > >>> > > > ACPI: platform_profile: Add a prefix to log messages > >>> > > > > >>> > > > .../ABI/testing/sysfs-class-platform-profile | 44 +++++ > >>> > > > drivers/acpi/platform_profile.c | 172 +++++++++++++----- > >>> > > > .../surface/surface_platform_profile.c | 48 ++--- > >>> > > > drivers/platform/x86/acer-wmi.c | 114 ++++++------ > >>> > > > drivers/platform/x86/amd/pmf/core.c | 1 - > >>> > > > drivers/platform/x86/amd/pmf/pmf.h | 3 +- > >>> > > > drivers/platform/x86/amd/pmf/sps.c | 51 +++--- > >>> > > > drivers/platform/x86/asus-wmi.c | 55 +++--- > >>> > > > drivers/platform/x86/dell/alienware-wmi.c | 34 ++-- > >>> > > > drivers/platform/x86/dell/dell-pc.c | 60 +++--- > >>> > > > drivers/platform/x86/hp/hp-wmi.c | 83 +++++---- > >>> > > > drivers/platform/x86/ideapad-laptop.c | 45 +++-- > >>> > > > .../platform/x86/inspur_platform_profile.c | 48 +++-- > >>> > > > drivers/platform/x86/thinkpad_acpi.c | 37 ++-- > >>> > > > include/linux/platform_profile.h | 37 ++-- > >>> > > > 15 files changed, 495 insertions(+), 337 deletions(-) > >>> > > > create mode 100644 Documentation/ABI/testing/sysfs-class-platform-profile > >>> > > > > >>> > > > > >>> > > > base-commit: d98bf6a6ed61a8047e199495b0887cce392f8e5b > >>> > > > -- > >>> > > > 2.48.1 > >>> > > > >>> > > For the series up to v4 commit 15/19: > >>> > > Reviewed-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx> > >>> > > > >>> > > I need to go over the last few commits just once more, as there a few > >>> > > pieces I need to get my head around - and I'm not going to get it done > >>> > > this evening. Hope it's OK to add review for the bits that I have done. > >>> > > >>> > I, for the first time ever, tested filter-branch and after some initial > >>> > hickups on how to specify the commit range, got your Reviewed-bys added > >>> > with single command :-). > >>> > >>> Awesome! I believe commit 15/19 > >>> > >>> a213108c01e0 ("ACPI: platform_profile: Remove platform_profile_handler from exported symbols") > >>> > >>> is still missing a rev-by by Mark, if there is still time. > >> > >> Thanks for noticing this. I just recalled the patch numbering wrong. > >> > >> It should be fixed now. > >> > >> -- > >> i. > > > > I finished my review, and no concerns. For the series: > > Reviewed-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx> > > > > Note - I'm building and will give it a sniff test too, but that will > > take a bit longer. > > > > Thanks for your work on this Kurt > > > Ran the series on an X1 Carbon G12 and profiles working well. Was able to check the new class and didn't find any issues. > For the series: > Tested-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx> Thanks a lot for testing this! I've added you tags into the entire series now. -- i.
