On Thu, 16 Jan 2025, Ai Chao wrote: > Follow the advice in Documentation/filesystems/sysfs.rst: > show() should only use sysfs_emit() or sysfs_emit_at() when formatting > the value to be returned to user space. > > Signed-off-by: Ai Chao <aichao@xxxxxxxxxx> Hi, I've now applied these 3 into the review-ilpo-next branch. Next time, however, please make a patch series out of cleanups of same kind so it'll be easier for me to handle them as a single set of patches. Thank you. -- i. > --- > drivers/platform/mellanox/mlxreg-io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/mellanox/mlxreg-io.c b/drivers/platform/mellanox/mlxreg-io.c > index 595276206baf..97fefe6c38d1 100644 > --- a/drivers/platform/mellanox/mlxreg-io.c > +++ b/drivers/platform/mellanox/mlxreg-io.c > @@ -126,7 +126,7 @@ mlxreg_io_attr_show(struct device *dev, struct device_attribute *attr, > > mutex_unlock(&priv->io_lock); > > - return sprintf(buf, "%u\n", regval); > + return sysfs_emit(buf, "%u\n", regval); > > access_error: > mutex_unlock(&priv->io_lock); >
