On Wed, Jan 15, 2025 at 8:07 PM Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote: > > On Mon, 13 Jan 2025 18:44:08 +0530, Hridesh MG wrote: > > > This patch improves the platform profile handling for laptops using the > > Acer Predator interface by making the following changes - > > > > 1) Using WMI calls to fetch the current platform profile instead of > > directly accessing it from the EC. A new helper function is > > introduced for this purpose. > > 2) Simplifying the cycling of platform profiles by making use of > > platform_profile_cycle() > > 3) Using an ACPI bitmap to dynamically set platform_profile_choices to > > better reflect the supported profiles. > > > > [...] > > > Thank you for your contribution, it has been applied to my local > review-ilpo-next branch. Note it will show up in the public > platform-drivers-x86/review-ilpo-next branch only once I've pushed my > local branch there, which might take a while. > > The list of commits applied: > [1/5] platform/x86: acer-wmi: use WMI calls for platform profile handling > commit: 2d76708c2221dde33d86aeef19f6d7d5f62148b4 > [2/5] platform/x86: acer-wmi: use new helper function for setting overclocks > commit: cd44e09bb89d4a33514b9ec3d972f0d2d13f5cfd > [3/5] platform/x86: acer-wmi: simplify platform profile cycling > commit: 61c461a90fbfc038d9663713f293d60fcb58c41d > [4/5] platform/x86: acer-wmi: use an ACPI bitmap to set the platform profile choices > commit: 191e21f1a4c3948957adc037734449f4a965dec5 > [5/5] platform/x86: acer-wmi: add support for Acer Nitro AN515-58 > commit: 549fcf58cf5837d401d0de906093169b05365609 > > -- > i. > Awesome, thanks a lot! I would like to once again thank Armin Wolf and Kurt Borja for their guidance and help in creating this patchset, this is my first meaningful [ to me atleast :) ] contribution to the kernel and I'm quite proud of it. Working on this issue was pretty fun and I learnt a lot regarding different things, it really did make me appreciate kernel developers even more. -- Thanks, Hridesh MG