On Fri, Jan 03, 2025 at 05:44:57PM +0100, Takashi Iwai wrote: > On Mon, 16 Dec 2024 13:20:08 +0100, > Baojun Xu wrote: > > > > This patch was used to add TAS2781 devices on SPI support in sound/pci/hda. > > It use ACPI node descript about parameters of TAS2781 on SPI, it like: > > Scope (_SB.PC00.SPI0) > > { > > Device (GSPK) > > { > > Name (_HID, "TXNW2781") // _HID: Hardware ID > > Method (_CRS, 0, NotSerialized) > > { > > Name (RBUF, ResourceTemplate () > > { > > SpiSerialBusV2 (...) > > SpiSerialBusV2 (...) > > } > > } > > } > > } > > > > And in platform/x86/serial-multi-instantiate.c, those spi devices will be > > added into system as a single SPI device, so TAS2781 SPI driver will > > probe twice for every single SPI device. And driver will also parser > > mono DSP firmware binary and RCA binary for itself. > > The code support Realtek as the primary codec. > > In patch version-10, add multi devices firmware binary support, > > to compatble with windows driver, they can share same firmware binary. ... > So this series reached already v12, and we'd really like to take in > some form. Although the code is still much more complex than I > wished, it's more or less readable and understandable in some level, > so I'm fine about the sound/* part. > > OTOH, this contains also the changes for drivers/acpi/scan.c and > drivers/platform/x86/serial-multi-instantiate.c, and those need Acks > from the corresponding people, but it missed Cc to them (and MLs). > Now I put them to Cc. > > Rafael, Hans, Ilpo, Andy, anyone else - could you guys check it?