On Mon, 06 Jan 2025 18:40:34 +0100, Maciej S. Szmigiero wrote: > Wakeup for IRQ1 should be disabled only in cases where i8042 had actually > enabled it, otherwise "wake_depth" for this IRQ will try to drop below zero > and there will be an unpleasant WARN() logged: > kernel: atkbd serio0: Disabling IRQ1 wakeup source to avoid platform firmware bug > kernel: ------------[ cut here ]------------ > kernel: Unbalanced IRQ 1 wake disable > kernel: WARNING: CPU: 10 PID: 6431 at kernel/irq/manage.c:920 irq_set_irq_wake+0x147/0x1a0 > > [...] Thank you for your contribution, it has been applied to my local review-ilpo-fixes branch. Note it will show up in the public platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my local branch there, which might take a while. The list of commits applied: [1/1] platform/x86/amd/pmc: Only disable IRQ1 wakeup where i8042 actually enabled it commit: dd410d784402c5775f66faf8b624e85e41c38aaf -- i.