Hi Thomas, On Fri, Jan 3, 2025, at 6:05 PM, Thomas Weißschuh wrote: > Looking at the users of firmware_attributes_class makes my head hurt. > Simplify the subsystem and its users. > > This will break the currently developed samsung-galaxybook driver, > resolving the breakage should be trivial. > > Only compile-tested. > > I have some further improvements in the pipeline building on these > changes, but those will need some more time. > > Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx> > --- > Thomas Weißschuh (6): > platform/x86: firmware_attributes_class: Move include linux/device/class.h > platform/x86: firmware_attributes_class: Simplify API > platform/x86: think-lmi: Directly use firmware_attributes_class > platform/x86: hp-bioscfg: Directly use firmware_attributes_class > platform/x86: dell-sysman: Directly use firmware_attributes_class > platform/x86: firmware_attributes_class: Drop lifecycle functions > > drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 17 +++------ > drivers/platform/x86/firmware_attributes_class.c | 42 +++++----------------- > drivers/platform/x86/firmware_attributes_class.h | 5 +-- > drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 14 ++------ > drivers/platform/x86/think-lmi.c | 13 ++----- > 5 files changed, 21 insertions(+), 70 deletions(-) > --- > base-commit: 0bc21e701a6ffacfdde7f04f87d664d82e8a13bf > change-id: 20250103-firmware-attributes-simplify-9ae561459260 > > Best regards, > -- > Thomas Weißschuh <linux@xxxxxxxxxxxxxx> For the series - looks good to me. Tested on X1 Carbon G12 and confirmed think-lmi is working as expected. Reviewed-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx> Tested-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx> Mark
