On Sun, Jan 5, 2025 at 9:31 AM SungHwan Jung <onenowy@xxxxxxxxx> wrote: > On 1/5/25 03:19, Hridesh MG wrote: > >> I think this should be kept. If the user changes profile manually this > >> may not reflect the actual last_non_turbo_profile. > > I thought that the purpose of last_non_turbo_profile was for > > acer_thermal_profile_change() to store the profile just before > > toggling turbo so that the system can return to it later on (as > > mentioned in the comments). I don't see a valid use case for this > > variable outside of that specific context, which is why I decided to > > remove its update during manual profile changes. > > > I think last_non_turbo_profile is still needed in > acer_predator_v4_platform_profile_set for returning from turbo mode set > by user space application in toggle mode. > > Without this, when users change profiles and set turbo mode using > applications or scripts (like predator sense GUI on windows) then use > the mode button to return from turbo mode, it returns to default or the > last value by the button, not the actual last profile. > Ah, I see now, that case seems to have slipped my mind. Thanks for pointing it out. -- Thanks, Hridesh MG
