On 1/4/25 06:07, Armin Wolf wrote: > That is some very important information right here. The platform-profile > documentation states: > > "Specifically when selecting a high performance profile the actual > achieved > performance may be limited by various factors such as: the heat > generated > by other components, room temperature, free air flow at the bottom > of a > laptop, etc. It is explicitly NOT a goal of this API to let > userspace know > about any sub-optimal conditions which are impeding reaching the > requested > performance level." > > I think the AC handling is unnecessary in this case as the hardware > seems to accept different profiles > even when not running on AC. This would simplify the platform profile > cycling inside the driver and > allow us to use platform_profile_cycle(). > > I wonder if this special behavior of the acer-wmi driver is documented > somewhere. I am asking this since > this has a great potential to confuse users. The acer_thermal_profile_change function was made for predator phn16-71 and tested with some predator laptop series. These predator series have the mode button that toggles between turbo or non-turbo or cycles each modes. And the predator sense app restricts these predator series to Eco and Balanced mode on battery. So this function includes on_AC to reflect these behaviors.(mentioned on comments) platform_profile_cycle() is suitable for cycle mode by cycle_gaming_thermal_profile parameter and if there is no reason to restrict thermal profiles on battery, we don't need to handle on_AC. But I'm not sure why the manufacturer restricts the thermal profiles on battery on windows. Thanks, SungHwan Jung > > Thanks, > Armin Wolf
