Re: [PATCH 06/20] alienware_wmi: Clean variable declaration in thermal methods

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 21.12.24 um 06:59 schrieb Kurt Borja:

Reorder variable declaration from longest to shortest.

Reviewed-by: Armin Wolf <W_Armin@xxxxxx>


Signed-off-by: Kurt Borja <kuurtb@xxxxxxxxx>
---
  drivers/platform/x86/dell/alienware-wmi.c | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/platform/x86/dell/alienware-wmi.c b/drivers/platform/x86/dell/alienware-wmi.c
index a431b1fec9fb..67cf376df0f5 100644
--- a/drivers/platform/x86/dell/alienware-wmi.c
+++ b/drivers/platform/x86/dell/alienware-wmi.c
@@ -923,13 +923,13 @@ static bool is_wmax_thermal_code(u32 code)

  static int wmax_thermal_information(u8 operation, u8 arg, u32 *out_data)
  {
-	acpi_status status;
  	struct wmax_u32_args in_args = {
  		.operation = operation,
  		.arg1 = arg,
  		.arg2 = 0,
  		.arg3 = 0,
  	};
+	acpi_status status;

  	status = alienware_wmax_command(&in_args, sizeof(in_args),
  					WMAX_METHOD_THERMAL_INFORMATION,
@@ -946,13 +946,13 @@ static int wmax_thermal_information(u8 operation, u8 arg, u32 *out_data)

  static int wmax_thermal_control(u8 profile)
  {
-	acpi_status status;
  	struct wmax_u32_args in_args = {
  		.operation = WMAX_OPERATION_ACTIVATE_PROFILE,
  		.arg1 = profile,
  		.arg2 = 0,
  		.arg3 = 0,
  	};
+	acpi_status status;
  	u32 out_data;

  	status = alienware_wmax_command(&in_args, sizeof(in_args),
@@ -970,13 +970,13 @@ static int wmax_thermal_control(u8 profile)

  static int wmax_game_shift_status(u8 operation, u32 *out_data)
  {
-	acpi_status status;
  	struct wmax_u32_args in_args = {
  		.operation = operation,
  		.arg1 = 0,
  		.arg2 = 0,
  		.arg3 = 0,
  	};
+	acpi_status status;

  	status = alienware_wmax_command(&in_args, sizeof(in_args),
  					WMAX_METHOD_GAME_SHIFT_STATUS,
@@ -1045,11 +1045,11 @@ static int thermal_profile_set(struct platform_profile_handler *pprof,

  static int create_thermal_profile(struct platform_device *platform_device)
  {
-	u32 out_data;
+	enum platform_profile_option profile;
+	enum wmax_thermal_mode mode;
  	u8 sys_desc[4];
  	u32 first_mode;
-	enum wmax_thermal_mode mode;
-	enum platform_profile_option profile;
+	u32 out_data;
  	int ret;

  	ret = wmax_thermal_information(WMAX_OPERATION_SYS_DESCRIPTION,





[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux