Am 23.12.24 um 00:06 schrieb Armin Wolf:
Am 21.12.24 um 06:58 schrieb Kurt Borja:
Hi :)
Hopefully these series are quite complete now. Your feedback is much
appreciated!
Previous discussions:
[1]
https://lore.kernel.org/platform-driver-x86/6m66cuivkzhcsvpjv4nunjyddqhr42bmjdhptu4bqm6rm7fvxf@qjwove4hg6gb/
[2]
https://lore.kernel.org/platform-driver-x86/20241205002733.2183537-3-kuurtb@xxxxxxxxx/
Comments
========
Patches 14 and 20 are proposals. Feel free to NACK them.
~ Kurt
Nice work, i will take a close look at those patches tomorrow.
Thanks,
Armin Wolf
It seems that i overestimated my time schedule during the Christmas holidays, sorry.
I will try to review those patches till new year.
Thanks,
Armin Wolf
---
Changes since RFC:
- Incorporated comments from Ilpo which include style and organization
issues
- Instead of splitting functionallity blocks, split WMI drivers
(Due to
Armin's comments)
- Replaced most of the patches near the end because of the above
change
- Some patches were squashed into eachother where it made sense
- Rebased on top of recent platform_profile changes!
Kurt Borja (20):
alienware-wmi: Remove unnecessary check at module exit
alienware-wmi: Move Lighting Control State
alienware-wmi: Modify parse_rgb() signature
alienware-wmi: Improve hdmi_mux, amplifier and deepslp group creation
alienware-wmi: Improve rgb-zones group creation
alienware_wmi: Clean variable declaration in thermal methods
alienware-wmi: Add a state container for LED control feature
alienware-wmi: Add WMI Drivers
alienware-wmi: Add a state container for thermal control methods
alienware-wmi: Refactor LED control methods
alienware-wmi: Refactor hdmi, amplifier, deepslp methods
alienware-wmi: Refactor thermal control methods
alienware-wmi: Split DMI table
MAINTAINERS: Update ALIENWARE WMI DRIVER entry
platform/x86: Rename alienware-wmi.c
platform/x86: Add alienware-wmi.h
platform-x86: Split the alienware-wmi driver
platform/x86: dell: Modify Makefile alignment
platform/x86: Update alienware-wmi config entries
alienware-wmi: Update header and module information
MAINTAINERS | 4 +-
drivers/platform/x86/dell/Kconfig | 30 +-
drivers/platform/x86/dell/Makefile | 45 +-
.../platform/x86/dell/alienware-wmi-base.c | 721 ++++++++++
.../platform/x86/dell/alienware-wmi-legacy.c | 89 ++
.../platform/x86/dell/alienware-wmi-wmax.c | 526 +++++++
drivers/platform/x86/dell/alienware-wmi.c | 1269 -----------------
drivers/platform/x86/dell/alienware-wmi.h | 103 ++
8 files changed, 1491 insertions(+), 1296 deletions(-)
create mode 100644 drivers/platform/x86/dell/alienware-wmi-base.c
create mode 100644 drivers/platform/x86/dell/alienware-wmi-legacy.c
create mode 100644 drivers/platform/x86/dell/alienware-wmi-wmax.c
delete mode 100644 drivers/platform/x86/dell/alienware-wmi.c
create mode 100644 drivers/platform/x86/dell/alienware-wmi.h
