On Mon, 23 Dec 2024, Mingcong Bai wrote: > From: xiaoxi404 <1577912515@xxxxxx> > > The HP OMEN 8 (2022), corresponding to a board ID of 8A15, supports OMEN > thermal profile and requires the timed profile quirk. > > Upon adding this ID to both the omen_thermal_profile_boards and > omen_timed_thermal_profile_boards, significant bump in performance can be > observed. For instance, SilverBench (https://silver.urih.com/) results > improved from ~56,000 to ~69,000, as a result of higher power draws (and > thus core frequencies) whilst under load: > > Package Power: > > - Before the patch: ~65W (dropping to about 55W under sustained load). > - After the patch: ~115W (dropping to about 105W under sustained load). > > Core Power: > > - Before: ~60W (ditto above). > - After: ~108W (ditto above). > > Add 8A15 to omen_thermal_profile_boards and > omen_timed_thermal_profile_boards to improve performance. > > Signed-off-by: xiaoxi404 <1577912515@xxxxxx> > Signed-off-by: Mingcong Bai <jeffbai@xxxxxxx> Hi, I wanted to apply this but the first signed-off-by line threw me off. It should contain person's name before the email address line like yours does (assuming the first signed-off-by is necessary in the first place, the patch itself looks quite trivial given it's just about adding one ID). -- i. > --- > drivers/platform/x86/hp/hp-wmi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c > index 81ccc96ffe40..20c55bab3b8c 100644 > --- a/drivers/platform/x86/hp/hp-wmi.c > +++ b/drivers/platform/x86/hp/hp-wmi.c > @@ -64,7 +64,7 @@ static const char * const omen_thermal_profile_boards[] = { > "874A", "8603", "8604", "8748", "886B", "886C", "878A", "878B", "878C", > "88C8", "88CB", "8786", "8787", "8788", "88D1", "88D2", "88F4", "88FD", > "88F5", "88F6", "88F7", "88FE", "88FF", "8900", "8901", "8902", "8912", > - "8917", "8918", "8949", "894A", "89EB", "8BAD", "8A42" > + "8917", "8918", "8949", "894A", "89EB", "8BAD", "8A42", "8A15" > }; > > /* DMI Board names of Omen laptops that are specifically set to be thermal > @@ -80,7 +80,7 @@ static const char * const omen_thermal_profile_force_v0_boards[] = { > * "balanced" when reaching zero. > */ > static const char * const omen_timed_thermal_profile_boards[] = { > - "8BAD", "8A42" > + "8BAD", "8A42", "8A15" > }; > > /* DMI Board names of Victus laptops */ >
