Re: [PATCH v2 2/3] platform: arm64: Add driver for EC found in most X1E laptops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 19, 2024 at 08:43:16PM +0000, Bryan O'Donoghue wrote:

> > +
> > +	val = i2c_smbus_read_byte_data(ec->client, EC_IRQ_REASON_REG);
> > +	if (val < 0) {
> > +		dev_err(dev, "Failed to get EC IRQ reason: %d\n", val);
> > +		return IRQ_HANDLED;
> > +	}
> > +
> > +	dev_info(dev, "Unhandled EC IRQ reason: %d\n", val);
> 
> Should an unhandled IRQ be an info or an err ?

Should be debug or ratelimit at most.

Best regards,
Krzysztof





[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux