Hi Hans, On 2024-12-17 16:18:47+0100, Hans de Goede wrote: > On 17-Dec-24 1:01 PM, Ilpo Järvinen wrote: > > On Wed, 11 Dec 2024, Hans de Goede wrote: > > > >> Make battery_modes a map between tokens and enum power_supply_charge_type > >> values instead of between tokens and strings and use the new > >> power_supply_charge_types_show/_parse() helpers for show()/store() > >> to ensure that things are handled in the same way as in other drivers. > >> > >> This also changes battery_supported_modes to be a bitmap of charge-types > >> (enum power_supply_charge_type values) rather then a bitmap of indices > >> into battery_modes[]. > >> > >> Reviewed-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx> > >> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> [..] > Note that merging this requires the earlier patches from this > series which have been merged into: > > https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git/log/?h=for-next > > so this either requires an immutable tag from Sebastian for you to merge, > or this should be merged through Sebastian's tree. If this goes in via the psy tree, you could already make it a power supply extension. The necessary code is in psy/for-next. Not necessary obviously. Thomas