On 12/15/24 08:09, Joshua Grisham wrote:
Den mån 9 dec. 2024 kl 18:04 skrev Randy Dunlap <rdunlap@xxxxxxxxxxxxx>:
Also needs <linux/sysfs.h>.
Maybe <linux/printk.h>.
Maybe <linux/err.h>.
--
~Randy
Also done in v2 of the patch, thanks Randy! (though no printk.h
anymore as I removed all pr_* functions.. maybe I should explicitly
add <linux/dev_printk.h> though? or is it good enough to get it via
platform_device.h <= device.h <= dev_printk.h ?)
Joshua
Your v2 is highly unusual. The patch description is the change log,
and the patch itself seems to be a diff against v1. Did someone ask you
to do that ? Just wondering.
Guenter
