Hi, On 10-Dec-24 6:03 PM, Thomas Weißschuh wrote: > On 2024-12-09 21:40:51+0100, Hans de Goede wrote: >> Make battery_modes a map between tokens and enum power_supply_charge_type >> values instead of between tokens and strings and use the new >> power_supply_charge_types_show/_parse() helpers for show()/store() >> to ensure that things are handled in the same way as in other drivers. >> >> This also changes battery_supported_modes to be a bitmap of charge-types >> (enum power_supply_charge_type values) rather then a bitmap of indices >> into battery_modes[]. >> >> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > This screams for power supply extensions. I fully agree! Regards, Hans