Hi,
On 5-Dec-24 10:03 AM, Andy Shevchenko wrote:
> On Wed, Dec 04, 2024 at 09:42:13PM +0100, Hans de Goede wrote:
>> Commit 06f876def346 ("platform/x86: x86-android-tablets: Add support for
>> Vexia EDU ATLA 10 tablet") omitted the static keyword from some variables
>> which are only used inside other.c .
>>
>> Add the missing static keyword to these, this fixes the following warnings:
>>
>> drivers/platform/x86/x86-android-tablets/other.c:605:12: sparse: sparse: symbol 'crystal_cove_pwrsrc_psy' was not declared. Should it be static?
>> drivers/platform/x86/x86-android-tablets/other.c:612:28: sparse: sparse: symbol 'vexia_edu_atla10_ulpmc_node' was not declared. Should it be static?
>
> I believe you can shorten these lines like
>
> .../x86-android-tablets/<and so on>
>
> (Note '...' instead of PDx86 root path.)
Fine by me, note that the warning will still not fit on a single 75
char line then though.
Ilpo do you want me to send a new version of the series for this?
> Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>
Thank you.
Regards,
Hans
