On Wed, Dec 4, 2024 at 7:40 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > On 28-Nov-24 4:51 PM, Andy Shevchenko wrote: > > On Thu, Nov 28, 2024 at 04:42:09PM +0100, Hans de Goede wrote: > >> Not all devices have an ACPI companion fwnode, so adev might be NULL. This > >> can e.g. (theoretically) happen when a user manually binds one of > >> the int3472 drivers to another i2c/platform device through sysfs. > >> > >> Add a check for adev not being set and return -ENODEV in that case. > > > > But what kind of "bad thing" can happen in such cases? > > NULL pointer deref oops in skl_int3472_get_acpi_buffer() during > probe() when it tries to get adev->handle. > > I guess for v2 you want me to reword the second paragraph of the commit > message to e.g. : > > Add a check for adev not being set and return -ENODEV in that case to > avoid a possible NULL pointer deref in skl_int3472_get_acpi_buffer(). > > ? I don't remember, but it sounds good to me. -- With Best Regards, Andy Shevchenko
