On Wed, Dec 4, 2024 at 7:36 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > On 28-Nov-24 4:52 PM, Andy Shevchenko wrote: > > On Thu, Nov 28, 2024 at 04:42:10PM +0100, Hans de Goede wrote: ... > >> - if (pin != agpio->pin_table[0]) > >> - dev_warn(int3472->dev, "%s %s pin number mismatch _DSM %d resource %d\n", > >> - func, agpio->resource_source.string_ptr, pin, > >> - agpio->pin_table[0]); > >> - > > > > Hmm... Perhaps move it to dev_dbg(FW_BUG) ? > > I'm not sure there is much value in keeping this. If we do go for dev_dbg() > then the check should be changed to: > > if (pin != (agpio->pin_table[0] % 256)) > > to avoid false positives and the need for that IMHO already shows that > there is little use in keeping the check. > > But lowering it to dev_dbg() + adding the % 256 also works for me, > please let me know how you want to proceed. I think dev_dbg() might still make (a little, though) sense. But also add a FW_BUG prefix to the message. -- With Best Regards, Andy Shevchenko
