On Wed, Nov 27, 2024 at 03:00:53PM +0900, Shin'ichiro Kawasaki wrote: > To prepare for the following fix, introduce the global flag > p2sb_hidden_by_bios. Check if the BIOS hides the P2SB device and store > the result in the flag. This allows to refer to the check result across > functions. Thinking about this I'm not sure we have no leftovers that are doing the hide-unhide dance on their own, behind p2sb_bar()'s back. But the idea is that all drivers that need this functionality in the kernel have to work through p2sb_bar() entry point. If any problem is found in the future with that, those will need to be fixed separately. -- With Best Regards, Andy Shevchenko