On Tue, 19 Nov 2024, Mario Limonciello wrote:
> The name attribute shows the name of the associated platform profile
> handler.
>
> Tested-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> ---
> v7:
> * Drop locking
> ---
> drivers/acpi/platform_profile.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> index 3524a2b4618ed..a9d7ec3c85844 100644
> --- a/drivers/acpi/platform_profile.c
> +++ b/drivers/acpi/platform_profile.c
> @@ -25,8 +25,32 @@ static_assert(ARRAY_SIZE(profile_names) == PLATFORM_PROFILE_LAST);
>
> static DEFINE_IDA(platform_profile_ida);
>
> +/**
> + * name_show - Show the name of the profile handler
> + * @dev: The device
> + * @attr: The attribute
> + * @buf: The buffer to write to
Add an empty line here after args.
> + * Return: The number of bytes written
> + */
> +static ssize_t name_show(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)
This fits to less lines.
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
--
i.
> +{
> + struct platform_profile_handler *handler = dev_get_drvdata(dev);
> +
> + return sysfs_emit(buf, "%s\n", handler->name);
> +}
> +
> +static DEVICE_ATTR_RO(name);
> +static struct attribute *profile_attrs[] = {
> + &dev_attr_name.attr,
> + NULL
> +};
> +ATTRIBUTE_GROUPS(profile);
> +
> static const struct class platform_profile_class = {
> .name = "platform-profile",
> + .dev_groups = profile_groups,
> };
>
> static ssize_t platform_profile_choices_show(struct device *dev,
>
