> Propagate led_classdev_register return value in case of error. > Call led_classdev_unregister in case sysfs_create_group fails. > > If alienware_zone_init fails, alienware_zone_exit should not be called > because the latter unregisters/removes the led class and the sysfs > group, which may not be registered/created if the former failed > prematurely. How do you think about to add any tags (like “Fixes” and “Cc”) accordingly? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12#n145 Regards, Markus