On Sat, Nov 16, 2024 at 5:17 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > On 16-Nov-24 1:16 PM, Hans de Goede wrote: > > On some Android tablets with Crystal Cove PMIC the DSDT lacks an ACPI AC > > device to indicate whether a charger is plugged in or not. > > > > Add support for registering a "crystal_cove_pwrsrc" power_supply class > > device to indicate charger online status. This is made conditional on > > a "linux,register-pwrsrc-power_supply" boolean device-property to avoid > > registering a duplicate power_supply class device on devices where this > > is already handled by an ACPI AC device. > > > > Note the "linux,register-pwrsrc-power_supply" property is only used on > > x86/ACPI (non devicetree) devs and the devicetree-bindings maintainers > > have requested properties like these to not be added to the devicetree > > bindings, so the new property is deliberately not added to any bindings. ... > > Changes in v2: > > - Adress a few small review remarks > > I forgot to add Andy's Reviewed-by, since the changes were very > minimal and all address remarks from Andy I presume that the review > still stands: > > Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx> Correct. -- With Best Regards, Andy Shevchenko