> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Sent: Wednesday, November 13, 2024 5:39 AM
> To: Ruhl, Michael J <michael.j.ruhl@xxxxxxxxx>
> Cc: intel-xe@xxxxxxxxxxxxxxxxxxxxx; platform-driver-x86@xxxxxxxxxxxxxxx;
> david.e.box@xxxxxxxxxxxxxxx; ilpo.jarvinen@xxxxxxxxxxxxxxx;
> hdegoede@xxxxxxxxxx; Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>; De Marchi,
> Lucas <lucas.demarchi@xxxxxxxxx>
> Subject: Re: [PATCH v2 0/2] Support BMG PMT features for Xe
>
> On Tue, Nov 12, 2024 at 11:30:33AM -0500, Michael J. Ruhl wrote:
> > Updates for PMT to support user offsets from the sysfs API.
> >
> > Addressed review comments for the Xe driver udpates.
>
> FWIW,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Thank you!
> If you have wish and time, there are problems with the drivers of different
I am working on this patch set in my spare time...If anything loosens up I will keep this
in mind.
M
> severities (from "fine as is" to "good to be fixed, but okay as is") I have noticed
> so far:
> - it uses s*printf() instead of sysfs_emit*()
> - it most likely never tested the corner cases. e.g.,
>
> if (disc_res->start >= pci_resource_start(pci_dev, i) &&
> (disc_res->start <= pci_resource_end(pci_dev, i))) {
>
> what is this supposed to mean? Probably someone wanted
> resource_contains() or
> alike to be called here.
> - slightly above the above piece the for-loop
>
> for (i = 0; i < 6; i++)
>
> which probably want to use PCI_STD_RESOURCE_END)
>
> --
> With Best Regards,
> Andy Shevchenko
>
