On Tue, 12 Nov 2024 12:04:49 +0000, Suma Hegde wrote: > Firmware is updated to send HSMP_ERR_PREREQ_NOT_SATISFIED(0xFD) and > HSMP_ERR_SMU_BUSY(0xFC) error codes. Add them here. > > Add error logs to make it easy to understand the failure reason for > different error conditions. > > Replace pr_err() with dev_err() to identify the driver printing the > error. > > [...] Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while. The list of commits applied: [1/2] platform/x86/amd/hsmp: Add new error code and error logs commit: 996b318e6fce255035efd555837d1250433bb0e7 [2/2] platform/x86/amd/hsmp: Change the error type commit: 8560b2775a08bf511576a18922c3bde920e69494 -- i.