On Thu, 7 Nov 2024, Shyam Sundar S K wrote:
> Instead of manually specifying num_ips, use ARRAY_SIZE() to set this value
> based on the actual number of elements in the array.
>
> Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> Co-developed-by: Sanket Goswami <Sanket.Goswami@xxxxxxx>
> Signed-off-by: Sanket Goswami <Sanket.Goswami@xxxxxxx>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>
> ---
> drivers/platform/x86/amd/pmc/pmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/amd/pmc/pmc.c b/drivers/platform/x86/amd/pmc/pmc.c
> index e03b576105a5..7c3204110bf8 100644
> --- a/drivers/platform/x86/amd/pmc/pmc.c
> +++ b/drivers/platform/x86/amd/pmc/pmc.c
> @@ -12,6 +12,7 @@
>
> #include <asm/amd_nb.h>
> #include <linux/acpi.h>
> +#include <linux/array_size.h>
> #include <linux/bitfield.h>
> #include <linux/bits.h>
> #include <linux/debugfs.h>
> @@ -117,7 +118,6 @@ static const struct amd_pmc_bit_map soc15_ip_blk[] = {
> {"IPU", BIT(19)},
> {"UMSCH", BIT(20)},
> {"VPE", BIT(21)},
> - {}
> };
>
> static bool disable_workarounds;
> @@ -169,7 +169,7 @@ static void amd_pmc_get_ip_info(struct amd_pmc_dev *dev)
> break;
> case PCI_DEVICE_ID_AMD_1AH_M20H_ROOT:
> case PCI_DEVICE_ID_AMD_1AH_M60H_ROOT:
> - dev->num_ips = 22;
> + dev->num_ips = ARRAY_SIZE(soc15_ip_blk);
> dev->smu_msg = 0x938;
> break;
> }
>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
--
i.
