Hi, On 31-Oct-24 4:40 PM, Kurt Borja wrote: > Fixes the following error: > > dell_smbios: Unable to run on non-Dell system > > Which is triggered after dell-wmi driver fails to initialize on > Alienware systems, as it depends on dell-smbios. > > This effectively extends dell-wmi, dell-smbios and dcdbas support to > Alienware devices, that might share some features of the SMBIOS intereface > calling interface with other Dell products. > > Tested on an Alienware X15 R1. > > Signed-off-by: Kurt Borja <kuurtb@xxxxxxxxx> Thank you for your patches, I've applied both patches to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note they will show up in my review-hans branch once I've pushed my local branch there, which might take a while. I will include these patches in my next fixes pull-req to Linus for the current kernel development cycle. Regards, Hans > > --- > v2: > - Commit message reflects Alienware devices may not necessarily support > the SMBIOS interface > - Commit message now has "Tested on" > --- > drivers/platform/x86/dell/dell-smbios-base.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/dell/dell-smbios-base.c b/drivers/platform/x86/dell/dell-smbios-base.c > index 73e41eb69..01c72b91a 100644 > --- a/drivers/platform/x86/dell/dell-smbios-base.c > +++ b/drivers/platform/x86/dell/dell-smbios-base.c > @@ -576,6 +576,7 @@ static int __init dell_smbios_init(void) > int ret, wmi, smm; > > if (!dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Dell System", NULL) && > + !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Alienware", NULL) && > !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "www.dell.com", NULL)) { > pr_err("Unable to run on non-Dell system\n"); > return -ENODEV;