On Wed, 30 Oct 2024, Mario Limonciello wrote:
> guard(mutex) can be used to automatically release mutexes when going
> out of scope.
>
> Tested-by: Matthew Schwartz <matthew.schwartz@xxxxxxxxx>
> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> Reviewed-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> ---
> drivers/acpi/platform_profile.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> index f2f2274e4d83e..cc2037147c0fd 100644
> --- a/drivers/acpi/platform_profile.c
> +++ b/drivers/acpi/platform_profile.c
> @@ -191,34 +191,29 @@ int platform_profile_register(struct platform_profile_handler *pprof)
> return -EINVAL;
> }
>
> - mutex_lock(&profile_lock);
> + guard(mutex)(&profile_lock);
> /* We can only have one active profile */
> - if (cur_profile) {
> - mutex_unlock(&profile_lock);
> + if (cur_profile)
> return -EEXIST;
> - }
>
> err = sysfs_create_group(acpi_kobj, &platform_profile_group);
> - if (err) {
> - mutex_unlock(&profile_lock);
> + if (err)
> return err;
> - }
> list_add_tail(&pprof->list, &platform_profile_handler_list);
>
> cur_profile = pprof;
> - mutex_unlock(&profile_lock);
> return 0;
> }
> EXPORT_SYMBOL_GPL(platform_profile_register);
>
> int platform_profile_remove(struct platform_profile_handler *pprof)
> {
> + guard(mutex)(&profile_lock);
> +
> list_del(&pprof->list);
>
> sysfs_remove_group(acpi_kobj, &platform_profile_group);
> - mutex_lock(&profile_lock);
> cur_profile = NULL;
> - mutex_unlock(&profile_lock);
> return 0;
> }
> EXPORT_SYMBOL_GPL(platform_profile_remove);
>
For patches 1-7,
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
--
i.
