On 10/29/2024 05:12, Ilpo Järvinen wrote:
On Sun, 27 Oct 2024, Mario Limonciello wrote:The sanity check that the platform handler had choices set doesn't need the mutex taken. Move it to earlier in the registration. Tested-by: Matthew Schwartz <matthew.schwartz@xxxxxxxxx> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> --- drivers/acpi/platform_profile.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c index 0c60fc970b6e8..c20256bb39579 100644 --- a/drivers/acpi/platform_profile.c +++ b/drivers/acpi/platform_profile.c @@ -180,6 +180,12 @@ int platform_profile_register(struct platform_profile_handler *pprof) { int err;+ /* Sanity check the profile handler field are set */+ if (!pprof || bitmap_empty(pprof->choices, PLATFORM_PROFILE_LAST) || + !pprof->profile_set || !pprof->profile_get) {While moving the line, please change the misleading indentation too (you'd have probably done it based on my comment on v1 too but since this series has changed things a bit, I'm noting it also against this patch).
Ack, thanks!
