Re: [PATCH v2 01/15] ACPI: platform-profile: Add a name member to handlers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/28/24 3:01 AM, Mario Limonciello wrote:
In order to prepare for allowing multiple handlers, introduce
a name field that can be used to distinguish between different
handlers.

Tested-by: Matthew Schwartz <matthew.schwartz@xxxxxxxxx>
Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
---
  drivers/platform/surface/surface_platform_profile.c | 1 +
  drivers/platform/x86/acer-wmi.c                     | 1 +
  drivers/platform/x86/amd/pmf/sps.c                  | 1 +
  drivers/platform/x86/asus-wmi.c                     | 1 +
  drivers/platform/x86/dell/dell-pc.c                 | 1 +
  drivers/platform/x86/hp/hp-wmi.c                    | 1 +
  drivers/platform/x86/ideapad-laptop.c               | 1 +
  drivers/platform/x86/inspur_platform_profile.c      | 1 +
  drivers/platform/x86/thinkpad_acpi.c                | 1 +
  include/linux/platform_profile.h                    | 1 +
  10 files changed, 10 insertions(+)

diff --git a/drivers/platform/surface/surface_platform_profile.c b/drivers/platform/surface/surface_platform_profile.c
index 3de864bc66108..61aa488a80eb5 100644
--- a/drivers/platform/surface/surface_platform_profile.c
+++ b/drivers/platform/surface/surface_platform_profile.c
@@ -211,6 +211,7 @@ static int surface_platform_profile_probe(struct ssam_device *sdev)
tpd->sdev = sdev; + tpd->handler.name = "Surface Platform Profile";
  	tpd->handler.profile_get = ssam_platform_profile_get;
  	tpd->handler.profile_set = ssam_platform_profile_set;
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index d09baa3d3d902..53fbc9b4d3df7 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -1878,6 +1878,7 @@ static int acer_platform_profile_setup(void)
  	if (quirks->predator_v4) {
  		int err;
+ platform_profile_handler.name = "acer-wmi";
  		platform_profile_handler.profile_get =
  			acer_predator_v4_platform_profile_get;
  		platform_profile_handler.profile_set =
diff --git a/drivers/platform/x86/amd/pmf/sps.c b/drivers/platform/x86/amd/pmf/sps.c
index 92f7fb22277dc..e2d0cc92c4396 100644
--- a/drivers/platform/x86/amd/pmf/sps.c
+++ b/drivers/platform/x86/amd/pmf/sps.c
@@ -405,6 +405,7 @@ int amd_pmf_init_sps(struct amd_pmf_dev *dev)
  		amd_pmf_set_sps_power_limits(dev);
  	}
+ dev->pprof.name = "amd-pmf";
  	dev->pprof.profile_get = amd_pmf_profile_get;
  	dev->pprof.profile_set = amd_pmf_profile_set;
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 2ccc23b259d3e..c7c104c65a85a 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -3910,6 +3910,7 @@ static int platform_profile_setup(struct asus_wmi *asus)
dev_info(dev, "Using throttle_thermal_policy for platform_profile support\n"); + asus->platform_profile_handler.name = "asus-wmi";
  	asus->platform_profile_handler.profile_get = asus_wmi_platform_profile_get;
  	asus->platform_profile_handler.profile_set = asus_wmi_platform_profile_set;
diff --git a/drivers/platform/x86/dell/dell-pc.c b/drivers/platform/x86/dell/dell-pc.c
index 972385ca1990b..3cf79e55e3129 100644
--- a/drivers/platform/x86/dell/dell-pc.c
+++ b/drivers/platform/x86/dell/dell-pc.c
@@ -247,6 +247,7 @@ static int thermal_init(void)
  	thermal_handler = kzalloc(sizeof(*thermal_handler), GFP_KERNEL);
  	if (!thermal_handler)
  		return -ENOMEM;
+	thermal_handler->name = "dell-pc";
  	thermal_handler->profile_get = thermal_platform_profile_get;
  	thermal_handler->profile_set = thermal_platform_profile_set;
diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
index 81ccc96ffe40a..26cac73caf2b9 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -1624,6 +1624,7 @@ static int thermal_profile_setup(void)
  		set_bit(PLATFORM_PROFILE_COOL, platform_profile_handler.choices);
  	}
+ platform_profile_handler.name = "hp-wmi";
  	set_bit(PLATFORM_PROFILE_BALANCED, platform_profile_handler.choices);
  	set_bit(PLATFORM_PROFILE_PERFORMANCE, platform_profile_handler.choices);
diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index 9d8c3f064050e..1f94c14c3b832 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -1102,6 +1102,7 @@ static int ideapad_dytc_profile_init(struct ideapad_private *priv)
mutex_init(&priv->dytc->mutex); + priv->dytc->pprof.name = "ideapad-laptop";
  	priv->dytc->priv = priv;
  	priv->dytc->pprof.profile_get = dytc_profile_get;
  	priv->dytc->pprof.profile_set = dytc_profile_set;
diff --git a/drivers/platform/x86/inspur_platform_profile.c b/drivers/platform/x86/inspur_platform_profile.c
index 8440defa67886..03da2c8cf6789 100644
--- a/drivers/platform/x86/inspur_platform_profile.c
+++ b/drivers/platform/x86/inspur_platform_profile.c
@@ -177,6 +177,7 @@ static int inspur_wmi_probe(struct wmi_device *wdev, const void *context)
  	priv->wdev = wdev;
  	dev_set_drvdata(&wdev->dev, priv);
+ priv->handler.name = "inspur-wmi";
  	priv->handler.profile_get = inspur_platform_profile_get;
  	priv->handler.profile_set = inspur_platform_profile_set;
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 4c1b0553f8720..c8c316b8507a5 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -10549,6 +10549,7 @@ static void dytc_profile_refresh(void)
  }
static struct platform_profile_handler dytc_profile = {
+	.name = "thinkpad-acpi",
  	.profile_get = dytc_profile_get,
  	.profile_set = dytc_profile_set,
  };
diff --git a/include/linux/platform_profile.h b/include/linux/platform_profile.h
index f5492ed413f36..6fa988e417428 100644
--- a/include/linux/platform_profile.h
+++ b/include/linux/platform_profile.h
@@ -27,6 +27,7 @@ enum platform_profile_option {
  };
struct platform_profile_handler {
+	const char *name;
  	unsigned long choices[BITS_TO_LONGS(PLATFORM_PROFILE_LAST)];
  	int (*profile_get)(struct platform_profile_handler *pprof,
  				enum platform_profile_option *profile);

Looks good to me.

Reviewed-by: Maximilian Luz <luzmaximilian@xxxxxxxxx>




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux