As support for multiple simultaneous platform handers is introduced it's
important they have at least the balanced profile in common.
This will be used as a fallback in case setting the profile across one of the
handlers happens to fail.
Tested-by: Matthew Schwartz <matthew.schwartz@xxxxxxxxx>
Suggested-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
---
drivers/acpi/platform_profile.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
index ede1550170f1a..c0d0775831214 100644
--- a/drivers/acpi/platform_profile.c
+++ b/drivers/acpi/platform_profile.c
@@ -190,9 +190,14 @@ int platform_profile_register(struct platform_profile_handler *pprof)
{
int err;
- /* Sanity check the profile handler field are set */
+ /* Sanity check the profile handler field are set and balanced is supported */
if (!pprof || bitmap_empty(pprof->choices, PLATFORM_PROFILE_LAST) ||
!pprof->profile_set || !pprof->profile_get) {
+ pr_err("platform_profile: handler is invalid\n");
+ return -EINVAL;
+ }
+ if (!test_bit(PLATFORM_PROFILE_BALANCED, pprof->choices)) {
+ pr_err("platform_profile: handler does not support balanced profile\n");
return -EINVAL;
}
--
2.43.0
