On 2024-10-25 07:55, Ilpo Järvinen wrote:
Per discussion on platform-driver-x86@xxxxxxxxxxxxxxx, this condition
indicates that the STB is not available.
If you want to refer to discussion, add it into a Link: tag. Only write
the conclusion into the commit message (the part you have there after
comma).
Thank you, I have added a Link tag to the mailing list archives.
I wanted to avoid taking credit for the claim, though--I don't have the
background to claim that on my own. I have changed the wording to refer
to Shyam Sundar S K, hoping that's an ok thing to do.
In order to avoid the ioremap warning, and to help the user understand
the situation, catch the invalid address and print an error.
Signed-off-by: Corey Hickey <bugfood-c@xxxxxxxxxx>
Isn't Fixes tag appropriate for this change?
Hmm... I didn't think so at first, but I guess so? I didn't do a git
bisect, but I can identify that the code in question was added by
3d7d407dfb05, so I added that as a Fixes tag.
---
drivers/platform/x86/amd/pmc/pmc.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/platform/x86/amd/pmc/pmc.c b/drivers/platform/x86/amd/pmc/pmc.c
index bbb8edb62e00..72b1dfc64bf1 100644
--- a/drivers/platform/x86/amd/pmc/pmc.c
+++ b/drivers/platform/x86/amd/pmc/pmc.c
@@ -998,6 +998,11 @@ static int amd_pmc_s2d_init(struct amd_pmc_dev *dev)
amd_pmc_send_cmd(dev, S2D_PHYS_ADDR_LOW, &phys_addr_low, dev->s2d_msg_id, true);
amd_pmc_send_cmd(dev, S2D_PHYS_ADDR_HIGH, &phys_addr_hi, dev->s2d_msg_id, true);
+ if (!phys_addr_hi && !phys_addr_low) {
+ dev_err(dev->dev, "amd_pmc: STB is not enabled on the system; disable enable_stb or contact system vendor\n");
Won't that end up duplicating the prefix if you put one into the string?
The prefix is handled for you by pr_fmt() which is already provided in
this file.
Ah, yes, I missed that.
Thank you for your review. I will submit a patch v2 momentarily.
-Corey
