On Mon, Oct 21, 2024 at 12:32 PM Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote: > On Mon, 21 Oct 2024, Andy Shevchenko wrote: ... > IMO, this change is doing too many things at once and it's hard to justify > why those changes must be kept in the same patch. If the guard() change > is done first and only then the logic reversions, both patches would > probably be near trivial to review for correctness. Are you insisting on this? Because that's how I have done similar changes in the past all over the kernel, and IIRC you are the first one asking for this :-) -- With Best Regards, Andy Shevchenko