Hi, On 10-Oct-24 1:05 AM, Abdul Rahim wrote: > The function strcpy() is depreciated and potentially unsafe. It performs > no bounds checking on the destination buffer. This could result in > linear overflows beyond the end of the buffer, leading to all kinds of > misbehaviors. The safe replacement is strscpy() [1]. > > this fixes checkpatch warning: > WARNING: Prefer strscpy over strcpy > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1] > Signed-off-by: Abdul Rahim <abdul.rahim@xxxxxxxxxxx> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> Regards, Hans > --- > drivers/platform/x86/asus-laptop.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c > index 9d7e6b712abf..d460dd194f19 100644 > --- a/drivers/platform/x86/asus-laptop.c > +++ b/drivers/platform/x86/asus-laptop.c > @@ -1832,8 +1832,8 @@ static int asus_acpi_add(struct acpi_device *device) > if (!asus) > return -ENOMEM; > asus->handle = device->handle; > - strcpy(acpi_device_name(device), ASUS_LAPTOP_DEVICE_NAME); > - strcpy(acpi_device_class(device), ASUS_LAPTOP_CLASS); > + strscpy(acpi_device_name(device), ASUS_LAPTOP_DEVICE_NAME); > + strscpy(acpi_device_class(device), ASUS_LAPTOP_CLASS); > device->driver_data = asus; > asus->device = device; >
