On Sat, Oct 05, 2024 at 10:27:04PM +0300, Andy Shevchenko wrote: > While design wise the idea of converting the driver to use > the hierarchy of the IRQ chips is correct, the implementation > has (inherited) flaws. This was unveiled when platform_get_irq() > had started WARN() on IRQ 0 that is supposed to be a Linux > IRQ number (also known as vIRQ). > > Rework the driver to respect IRQ domain when creating each MFD > device separately, as the domain is not the same for all of them. > > Fixes: 9c6235c86332 ("mfd: intel_soc_pmic_bxtwc: Add bxt_wcove_usbc device") > Fixes: d2061f9cc32d ("usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY") > Fixes: 57129044f504 ("mfd: intel_soc_pmic_bxtwc: Use chained IRQs for second level IRQ chips") > Reported-by: Zhang Ning <zhangn1985@xxxxxxxxxxx> > Closes: https://lore.kernel.org/r/TY2PR01MB3322FEDCDC048B7D3794F922CDBA2@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx > Tested-by: Zhang Ning <zhangn1985@xxxxxxxxxxx> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>