Re: [PATCH v2 0/3] platform/x86: dell-laptop: Battery hook fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 30, 2024 at 8:53 PM Armin Wolf <W_Armin@xxxxxx> wrote:
>
> Am 22.09.24 um 08:40 schrieb Armin Wolf:
>
> > This patch series fixes some issues around the battery hook handling
> > inside the ACPI battery driver and the dell-laptop driver.
> >
> > The first patch simplifies the locking during battery hook removal as
> > a preparation for the second patch which fixes a possible crash when
> > unregistering a battery hook.
> >
> > The third patch allows the dell-laptop driver to handle systems with
> > multiple batteries.
> >
> > All patches where tested on a Dell Inspiron 3505 and appear to work.
>
> Any thoughts from the ACPI maintainers?

The first patch looks good to me, but I have a comment regarding the second one.

I'll get to this tomorrow.

> > Changes since v1:
> > - fix the underlying issue inside the ACPI battery driver
> > - reword patch for dell-laptop
> >
> > Armin Wolf (3):
> >    ACPI: battery: Simplify battery hook locking
> >    ACPI: battery: Fix possible crash when unregistering a battery hook
> >    platform/x86: dell-laptop: Do not fail when encountering unsupported
> >      batteries
> >
> >   drivers/acpi/battery.c                  | 27 ++++++++++++++++---------
> >   drivers/platform/x86/dell/dell-laptop.c | 15 +++++++++++---
> >   include/acpi/battery.h                  |  1 +
> >   3 files changed, 31 insertions(+), 12 deletions(-)
> >
> > --





[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux