Re: [PATCH v1 3/4] acpi/x86: s2idle: call screen on and off as part of callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Denis,

> Beside, as for necessary kernel/software quirks, the new firmware is
> expected to require none, at least for asus-wmi, so I ask you to leave
> csee calls where they are now as in the future those will be used only
> on non-updated firmware.

I'm happy you said that, as it means this patch will not conflict with
the new firmware and will just fix older devices.

The only change my patch does on the Ally specifically is pull CSEE
earlier and remove the extra call. There is nothing in this patch to
explain what you are experiencing. There are a lot of causes I could
point my finger to, but there is no point.

We will conduct our own testing, and this will include the original
Ally as well. A lot of them actually, and after initial testing this
will include thousands of devices, as we plan to fully dogfood this
patch.

I was a bit busy today, so I did not update the patch. I want to
rewrite part of the cover letter, as it includes some inconsistencies,
and rename some variables. The inconsistencies have to do with how I
describe the sleep stage, as I read up on some additional
documentation, it is not related to the contents of the patch. In
addition, it seems those sleep _DSMs cause problems on the Ally too,
related to TDP. And no, I will not wait half a year for a BIOS update
to fix those.

I am also looking into how to integrate Modern Standby into the
kernel, in a more full featured way. Downloading games in the
background is a very requested feature after all, and since looking
into the Ally's _DSM entries, it seems like it is built to support it.
Background here would mean the fan will be off and the suspend light
will be pulsing, so you can safely stow it in a bag while it is
downloading games. However, this is conjecture until the patch for
that is built and tested.

Antheas




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux