On Mon, Sep 09, 2024 at 09:40:36PM GMT, Ilpo Järvinen wrote: > > Thank you for your contribution, it has been applied to my local > > review-ilpo branch. Note it will show up in the public > > platform-drivers-x86/review-ilpo branch only once I've pushed my > > local branch there, which might take a while. > > > > The list of commits applied: > > [1/3] platform/x86: panasonic-laptop: Fix SINF array out of bounds accesses > > commit: f52e98d16e9bd7dd2b3aef8e38db5cbc9899d6a4 > > [2/3] platform/x86: panasonic-laptop: Allocate 1 entry extra in the sinf array > > commit: 33297cef3101d950cec0033a0dce0a2d2bd59999 > > [3/3] platform/x86: panasonic-laptop: Add support for programmable buttons > > (no commit info) > > Hmpf, b4 messed this one up. Only patches 1-2 were applied and 3 should > go through for-next. Hi: This is a common gotcha and I'm hoping to make it less of a problem in the future. The reason this happened is because you told b4 to retrieve the entire patch series, but applied only a subset. We couldn't find a match for patch 3/3, but this often happens because maintainers make small tweaks to patch contents, which skews b4 towards false-negatives instead of false-positives. For the moment, the preferred way to avoid this problem is to tell b4 to retrieve a subset of patches using `b4 am --cherry-pick 1-2` -- this way we know that it was intended to be a subset and won't mention patch 3. Hope this helps! -K
