On Tue, Sep 3, 2024 at 1:35 PM Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote: > On Tue, 3 Sep 2024, Hans de Goede wrote: ... > > - key = result & 0xf; > > + key = result & 0x7f; Wondering if moving to GENMASK() (and BIT() respectively in other line(s)) would help reader as well and in commit message to mention the bit field size(s). > I'd mention this in the commit message. It's kind of different from adding > just keys. -- With Best Regards, Andy Shevchenko
