On Thu, Aug 22, 2024 at 11:46:33AM +0200, Hans de Goede wrote: > Hi, > > On 8/21/24 8:15 PM, Dmitry Torokhov wrote: > > On Wed, Aug 21, 2024 at 12:15:51PM +0200, Hans de Goede wrote: > >> Hi Dmitry, > >> > >> On 8/21/24 7:25 AM, Dmitry Torokhov wrote: > >>> Convert GPIO-connected buttons and LEDs in Geode boards to software > >>> nodes/properties, so that support for platform data can be removed from > >>> gpio-keys driver (which will rely purely on generic device properties > >>> for configuration). > >>> > >>> To avoid repeating the same data structures over and over and over > >>> factor them out into a new geode-common.c file. > >>> > >>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > >> > >> Thanks, patch looks good to me: > >> > >> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> > >> > >> Question has this been tested on at least 1 affected device ? > > > > No unfortunately it has not been as I do not have the hardware. I am > > hoping folks on geode list could give this patch a spin. > > Ok. I assume this is part of some bigger plan to remove platform_data > support from either LEDs and/or the GPIO buttons ? Can't say about LEDs but yes about GPIO buttons and input devices in general. I would like to move all of them to generic device properties. > > I would rather not merge this untested, but if it is part of some > bigger plan, then I'm ok with merging this if still no-one has tested > this when the rest of the bits for the plan are ready. > > IOW lets wait a bit to see if someone steps up to test and of not > then lets merge this before it becomes a blocker for further changes. OK, I have a few other boards for which I am trying to push similar changes through, once they are done I'll bug you again. Thanks. -- Dmitry
