Hi,
A quick comment as I failed to understand your commit message.
On Thu, 22 Aug 2024, Gergo Koteles wrote:
> While booting, Lenovo 14ARB7 reports 'lenovo-ymc: Unknown key 0 pressed'
> warning. Because lenovo_ymc_probe() calls lenovo_ymc_notify() and that
> time the YMC part is not triggered yet
This sentence should be rephrased as is it doesn't seem to make sense.
Or is the . before it in wrong place and should be removed?
> (which is mandatory for this
> model).
If the latter of the options above is the right one, I cannot connect the
meaning of this parenthesis part with the full sentence. That is, what is
mandatory in that case? So you might have to rephrase it as well.
> At the end of lenovo_ymc_notify() YMC is triggered by the
> ideapad-laptop driver and then lenovo_ymc_notify() will be called by WMI
> to report the actual value.
--
i.
>
> Add 0x0 YMC state to the sparse keymap to ignore.
>
> Signed-off-by: Gergo Koteles <soyer@xxxxxx>
> ---
> drivers/platform/x86/lenovo-ymc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/platform/x86/lenovo-ymc.c b/drivers/platform/x86/lenovo-ymc.c
> index e0bbd6a14a89..bd9f95404c7c 100644
> --- a/drivers/platform/x86/lenovo-ymc.c
> +++ b/drivers/platform/x86/lenovo-ymc.c
> @@ -43,6 +43,8 @@ struct lenovo_ymc_private {
> };
>
> static const struct key_entry lenovo_ymc_keymap[] = {
> + /* Ignore the uninitialized state */
> + { KE_IGNORE, 0x00 },
> /* Laptop */
> { KE_SW, 0x01, { .sw = { SW_TABLET_MODE, 0 } } },
> /* Tablet */
>
