On Wed, Aug 21, 2024 at 03:38:15PM +0300, Ilpo Järvinen wrote: > On Wed, 21 Aug 2024, Andy Shevchenko wrote: > > > In the similar way, ignore 0 error code (AKA "success") in > > dev_err_probe(). This helps to simplify a code such as > > > > if (ret < 0) > > return dev_err_probe(int3472->dev, ret, err_msg); > > > > return ret; > > > > to > > > > return dev_err_probe(int3472->dev, ret, err_msg); ... > This seems generally useful, > > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> Thanks! > A nit, the code sequence that dev_err_probe() is documented to replace is > no longer matches with the behavior (the else would need if (err < 0) > added). Okay, let's wait what Greg says about it, if he is okay with the proposal, I'll amend documentation as well in v2. -- With Best Regards, Andy Shevchenko
