On Wed, 21 Aug 2024, Andy Shevchenko wrote:
> Use modern string_choices API instead of manually determining the
> output using ternary operator.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/platform/x86/intel/hid.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
> index 10cd65497cc1..445e7a59beb4 100644
> --- a/drivers/platform/x86/intel/hid.c
> +++ b/drivers/platform/x86/intel/hid.c
> @@ -13,6 +13,7 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> +#include <linux/string_choices.h>
> #include <linux/suspend.h>
> #include "../dual_accel_detect.h"
>
> @@ -331,10 +332,8 @@ static int intel_hid_set_enable(struct device *device, bool enable)
> acpi_handle handle = ACPI_HANDLE(device);
>
> /* Enable|disable features - power button is always enabled */
> - if (!intel_hid_execute_method(handle, INTEL_HID_DSM_HDSM_FN,
> - enable)) {
> - dev_warn(device, "failed to %sable hotkeys\n",
> - enable ? "en" : "dis");
> + if (!intel_hid_execute_method(handle, INTEL_HID_DSM_HDSM_FN, enable)) {
> + dev_warn(device, "failed to %s hotkeys\n", str_enable_disable(enable));
> return -EIO;
> }
>
>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
--
i.
