Hi, On 8/19/24 8:34 AM, Shyam Sundar S K wrote: > The CPU ID macros are needed by the Smart PC builder. Therefore, transfer > the CPU ID macros from core.c to the common PMF header file. > > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > Co-developed-by: Patil Rajesh Reddy <Patil.Reddy@xxxxxxx> > Signed-off-by: Patil Rajesh Reddy <Patil.Reddy@xxxxxxx> > Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx> Thank you for your patch-series, I've applied the series to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > v4: > - Add Reviewed-by Tag > > V3: > - No change > > V2: > - No change > > drivers/platform/x86/amd/pmf/core.c | 6 ------ > drivers/platform/x86/amd/pmf/pmf.h | 6 ++++++ > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c > index 8f1f719befa3..88314b0277a3 100644 > --- a/drivers/platform/x86/amd/pmf/core.c > +++ b/drivers/platform/x86/amd/pmf/core.c > @@ -37,12 +37,6 @@ > #define AMD_PMF_RESULT_CMD_UNKNOWN 0xFE > #define AMD_PMF_RESULT_FAILED 0xFF > > -/* List of supported CPU ids */ > -#define AMD_CPU_ID_RMB 0x14b5 > -#define AMD_CPU_ID_PS 0x14e8 > -#define PCI_DEVICE_ID_AMD_1AH_M20H_ROOT 0x1507 > -#define PCI_DEVICE_ID_AMD_1AH_M60H_ROOT 0x1122 > - > #define PMF_MSG_DELAY_MIN_US 50 > #define RESPONSE_REGISTER_LOOP_MAX 20000 > > diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h > index 9bf4326d06c3..9fc26f672f12 100644 > --- a/drivers/platform/x86/amd/pmf/pmf.h > +++ b/drivers/platform/x86/amd/pmf/pmf.h > @@ -19,6 +19,12 @@ > #define POLICY_SIGN_COOKIE 0x31535024 > #define POLICY_COOKIE_OFFSET 0x10 > > +/* List of supported CPU ids */ > +#define AMD_CPU_ID_RMB 0x14b5 > +#define AMD_CPU_ID_PS 0x14e8 > +#define PCI_DEVICE_ID_AMD_1AH_M20H_ROOT 0x1507 > +#define PCI_DEVICE_ID_AMD_1AH_M60H_ROOT 0x1122 > + > struct cookie_header { > u32 sign; > u32 length;
