Hi, On 8/5/24 10:27 PM, Andy Shevchenko wrote: > On Mon, Aug 5, 2024 at 3:38 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> >> Move the SMO88xx acpi_device_ids to a new dell-smo8800-ids.h header, >> so that these can be shared with the new dell-lis3lv02d code. > > ... > >> +#ifndef _DELL_SMO8800_IDS_H_ >> +#define _DELL_SMO8800_IDS_H_ >> + >> +#include <linux/mod_devicetable.h> >> + >> +static const struct acpi_device_id smo8800_ids[] = { >> + { "SMO8800" }, >> + { "SMO8801" }, >> + { "SMO8810" }, >> + { "SMO8811" }, >> + { "SMO8820" }, >> + { "SMO8821" }, >> + { "SMO8830" }, >> + { "SMO8831" }, >> + { } >> +}; >> +MODULE_DEVICE_TABLE(acpi, smo8800_ids); > > The macro definition is in module.h. Ok, I've added a #include for that for v8. Regards, Hans