Hi, On 7/13/24 6:35 PM, Mustafa Ekşi wrote: > Hi, I apologize for the delay. I recently saw Carlos's patch and your > reviews, so I improved my driver according to it and made it ready for > another version. > > I didn't include the documentation for the new zoned keyboard backlight > naming since Carlos is going to do that. However, I changed the naming of > corner led because it isn't affected when other zones' brightness changes. > And one last reason to not name it kbd_zoned_backlight is the fact that it > isn't on the keyboard, it's on the two corners of the laptop. I'm still not > sure how to name it, so I named it 'backlight'. > Here's a photo of the laptop: https://imgur.com/a/JEqMiGL Thanks for the photo very helpful. I see these corner LEDs actually illuminate the table, not the laptop itself, a bit like ambilight on Philips television sets. According to wikipedia the vendor neutral not trademarked name for this is bias-lighting: https://en.wikipedia.org/wiki/Bias_lighting So lets name it "casper:rgb:biaslight", which I admittedly is a bit weird, but backlight for LEDs which are not actually a backlight for displays or keys is confusing, so IMHO biaslight is best. Regards, Hans p.s. I'm also doing a review of the patch itself, but I likely will not finish that today. > > Mustafa Ekşi (1): > platform/x86: Add wmi driver for Casper Excalibur laptops > > MAINTAINERS | 6 + > drivers/platform/x86/Kconfig | 14 + > drivers/platform/x86/Makefile | 1 + > drivers/platform/x86/casper-wmi.c | 656 ++++++++++++++++++++++++++++++ > 4 files changed, 677 insertions(+) > create mode 100644 drivers/platform/x86/casper-wmi.c >
