Hi Peter, On Wed, Jul 31, 2024 at 10:50 PM Peter Kästle <xypiie@xxxxxxxxx> wrote: > > Hi Rafael, > > On 30.07.24 20:33, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > > > Make the acerhdf driver use the .should_bind() thermal zone > > callback to provide the thermal core with the information on whether or > > not to bind the given cooling device to the given trip point in the > > given thermal zone. If it returns 'true', the thermal core will bind > > the cooling device to the trip and the corresponding unbinding will be > > taken care of automatically by the core on the removal of the involved > > thermal zone or cooling device. > > > > The previously existing acerhdf_bind() function bound cooling devices > > to thermal trip point 0 only, so the new callback needs to return 'true' > > for trip point 0. However, it is straightforward to observe that trip > > point 0 is an active trip point and the only other trip point in the > > driver's thermal zone is a critical one, so it is sufficient to return > > 'true' from that callback if the type of the given trip point is > > THERMAL_TRIP_ACTIVE. > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > Thanks for including me on the review. > I'm working on it, but unfortunately the refactoring of the thermal layer > around gov_bang_bang.c earlier this year broke acerhdf. Well, sorry about that. > This needs some debugging and refactoring. I think I can finish it on > upcoming weekend. Thank you! I'll be offline next week, so I'll go back to this material in two weeks or so anyway.
