Hi David On Thu, Jul 11, 2024 at 5:34 PM David E. Box <david.e.box@xxxxxxxxxxxxxxx> wrote: > > Hi Marek. Thanks for the patch. > > On Wed, 2024-07-03 at 12:30 -0400, Rajneesh Bhardwaj wrote: > > On Wed, Jul 3, 2024 at 7:39 AM Marek Maslanka <mmaslanka@xxxxxxxxxx> wrote: > > > > > > Allow to disable ACPI PM Timer on suspend and enable on resume. A > > > disabled timer helps optimise power consumption when the system is > > > suspended. On resume the timer is only reactivated if it was activated > > > prior to suspend, so unless the ACPI PM timer is enabled in the BIOS, > > > this won't change anything. > > > > Back in the days IIRC, it was frowned upon but I am not sure anymore. > > Maybe Rafael or David will have some opinion on this change. Is this > > something that could be done in a platform specific manner such as in > > coreboot? > > I discussed with Rafael. This is generally a good idea, but need to ensure that > the ACPI PM Timer isn't being used as a clock source. This could mess with the > timekeeping system. Also, maybe a better idea is to disable it altogether at > probe time if it's not being used as a clock source. This should only be the > case when TSC is unstable and HPET is unavailable, but need to confirm. > > David >
