On Thu, 11 Jul 2024, Nikita Travkin wrote: > Geert Uytterhoeven писал(а) 11.07.2024 19:30: > > The Acer Aspire 1 Embedded Controller is only present on the Qualcomm > > Snapdragon-based Acer Aspire 1 laptop. Hence add a dependency on > > ARCH_QCOM, to prevent asking the user about this driver when configuring > > a kernel without Qualcomm SoC support. > > > > Oh yeah, you're right. Thanks for fixing this! > > Acked-by: Nikita Travkin <nikita@xxxxxxx> > > We should probably do the same for the C630 driver as well... Yes, Geert sent another patch for that already. -- i. > > Fixes: 2b3efb7c515111ea ("platform: arm64: Add Acer Aspire 1 embedded controller driver") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > --- > > drivers/platform/arm64/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig > > index 8c103b3150d1d0a6..058a4baa216a83b8 100644 > > --- a/drivers/platform/arm64/Kconfig > > +++ b/drivers/platform/arm64/Kconfig > > @@ -18,6 +18,7 @@ if ARM64_PLATFORM_DEVICES > > > > config EC_ACER_ASPIRE1 > > tristate "Acer Aspire 1 Embedded Controller driver" > > + depends on ARCH_QCOM || COMPILE_TEST > > depends on I2C > > depends on DRM > > depends on POWER_SUPPLY >