Hi, As suggested, this driver now uses the multicolor led api. Please note that for brightness, it takes the brightness files in each zone and uses them as one as there is no per zone brightness control, so all the files control the brightness of the entire keyboard. Also, when the backlight toggle key is pressed it updates the brightness on all the zones to avoid some edge case problems i ran into where setting the same color more than once would set the brightness to the previous value. Please let me know if this is a good approach. Carlos Ferreira (1): HP: wmi: added support for 4 zone keyboard rgb drivers/platform/x86/hp/hp-wmi.c | 248 +++++++++++++++++++++++++++++-- 1 file changed, 239 insertions(+), 9 deletions(-) -- 2.45.2